Skip to content

fix(create): nest nitro rollup config - #457

Open
jong-kyung wants to merge 10 commits into
TanStack:mainfrom
jong-kyung:fix/nitro-rollup-config
Open

fix(create): nest nitro rollup config#457
jong-kyung wants to merge 10 commits into
TanStack:mainfrom
jong-kyung:fix/nitro-rollup-config

Conversation

@jong-kyung

@jong-kyung jong-kyung commented Jun 3, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

Generated React Nitro/Railway projects now pass Sentry rollup externals through Nitro's config option. This avoids the type error caused by passing rollupConfig at the top level of the Nitro Vite plugin options.

Validation

  • pnpm --filter @tanstack/create build
  • pnpm --filter @tanstack/create test

Summary by CodeRabbit

  • Chores
    • Updated build configuration structure for Nitro and Railway hosting integrations to align with current plugin requirements.
    • Preserved external handling for Sentry packages during builds.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Two hosting integration snippets now nest rollupConfig inside a config object within nitro(). Both snippets preserve the @sentry/ externalization rule.

Changes

Nitro Configuration Examples

Layer / File(s) Summary
Nitro config structure update
packages/create/src/frameworks/react/hosts/nitro/info.json, packages/create/src/frameworks/react/hosts/railway/info.json		 Both configuration snippets now place rollupConfig inside config while preserving the @sentry/ external pattern.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: nesting the Nitro rollup configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jong-kyung